-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise the release process #3894
Revise the release process #3894
Conversation
@leleliu008 could you review f94bdfa ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3894 +/- ##
=======================================
Coverage 85.29% 85.29%
=======================================
Files 232 232
Lines 55786 55786
=======================================
Hits 47582 47582
Misses 8204 8204 ☔ View full report in Codecov by Sentry. |
903489a
to
1a4c6f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we usually say
creating an annotation tag
, I never saw someone saidputting an annotation tag
, so I think it would be better to change the wordputting
tocreating
NOTE: for putting an annotation tag, we need a GitHub account for the user.
I,m not clear what you mean. we use GitHub Actions to create a new tag, I myself hope our project's tag page could display a line likegithub-actions tagged this
, rather than the HEAD commit's commiter.
If we want to display something like |
@leleliu008 Thank you. I don't want to make an annotation tag for a snapshot. So displaying the HEAD commit's commiter is ok. I don't want to increase the number of commits just for making snapshots. At the initial comment in #3767, you wrote:
I implemented what I wrote here in f94bdfa. Do I misunderstand what you wrote? |
@masatake There is no misunderstandings. |
@leleliu008 Thank you for confirmation. I will remove the comments newly added in this pull request. |
…d ctags.h Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…of the script Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
… when releasing Signed-off-by: Masatake YAMATO <yamato@redhat.com>
1a4c6f5
to
53c0e97
Compare
Close #3767.