Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the release process #3894

Merged
merged 5 commits into from
Dec 23, 2023

Conversation

masatake
Copy link
Member

Close #3767.

@masatake
Copy link
Member Author

@leleliu008 could you review f94bdfa ?
See #3767.

@masatake masatake changed the title Revise release process Revise the release process Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4871bfc) 85.29% compared to head (53c0e97) 85.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3894   +/-   ##
=======================================
  Coverage   85.29%   85.29%           
=======================================
  Files         232      232           
  Lines       55786    55786           
=======================================
  Hits        47582    47582           
  Misses       8204     8204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masatake masatake added this to the 6.1 milestone Dec 22, 2023
Copy link
Member

@leleliu008 leleliu008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. we usually say creating an annotation tag, I never saw someone said putting an annotation tag, so I think it would be better to change the word putting to creating
  2. NOTE: for putting an annotation tag, we need a GitHub account for the user. I,m not clear what you mean. we use GitHub Actions to create a new tag, I myself hope our project's tag page could display a line like github-actions tagged this , rather than the HEAD commit's commiter.

@leleliu008
Copy link
Member

leleliu008 commented Dec 22, 2023

If we want to display something like github-actions tagged this, we need to use github-cli I guess, if we use git command, github would display universal-ctags tagged this, because tagger's email Universal-ctags@users.noreply.github.com belongs to universal-ctags account.

@masatake
Copy link
Member Author

@leleliu008 Thank you.

I don't want to make an annotation tag for a snapshot. So displaying the HEAD commit's commiter is ok. I don't want to increase the number of commits just for making snapshots.

At the initial comment in #3767, you wrote:

If you think current is good enough, I think we should remove the Universal-ctags CI and Universal-ctags@users.noreply.github.com or add more comments.

I implemented what I wrote here in f94bdfa. Do I misunderstand what you wrote?

@leleliu008
Copy link
Member

@masatake There is no misunderstandings.

@masatake
Copy link
Member Author

@leleliu008 Thank you for confirmation. I will remove the comments newly added in this pull request.

…d ctags.h

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…of the script

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
… when releasing

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake merged commit bea6f5b into universal-ctags:master Dec 23, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create annotation tags instead of lightweight tag
2 participants