Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18nRubyGem: new parser #3895

Merged
merged 11 commits into from
Dec 27, 2023
Merged

I18nRubyGem: new parser #3895

merged 11 commits into from
Dec 27, 2023

Conversation

masatake
Copy link
Member

@masatake masatake commented Dec 23, 2023 •
edited
Loading

Close #3523

TODO:

  • revise dd52763.
  • add a case giving unexpected input
  • add localeful extra (there may be cases that qualified extra doesn't fit)

@masatake masatake force-pushed the I18NRubyGem branch 3 times, most recently from dda57e5 to 50734e1 Compare December 23, 2023 06:39
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (bea6f5b) 85.29% compared to head (bc3aa34) 85.31%.
Report is 2 commits behind head on master.

Files Patch % Lines
main/entry.c 60.00% 8 Missing ⚠️
parsers/i18nrubygem.c 99.15% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3895      +/-   ##
==========================================
+ Coverage   85.29%   85.31%   +0.02%     
==========================================
  Files         232      233       +1     
  Lines       55786    55911     +125     
==========================================
+ Hits        47582    47703     +121     
- Misses       8204     8208       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masatake
Copy link
Member Author

I must add more comments to the change, dd52763.

@masatake masatake added this to the 6.1 milestone Dec 23, 2023
@masatake masatake mentioned this pull request Dec 23, 2023
Closed
akemrir
akemrir reviewed Dec 23, 2023
View reviewed changes
parsers/i18nrubygem.c Outdated Show resolved Hide resolved
@masatake masatake force-pushed the I18NRubyGem branch 2 times, most recently from e508130 to 36a37b0 Compare December 23, 2023 18:43
@masatake
Copy link
Member Author

dae5d14 before merging this pull request, I must revise this commit.

@masatake
Copy link
Member Author

@akemrir, can I ask you to reivew the new man page, docs(man): add a page for I18nRubyGem ?

@masatake masatake closed this Dec 25, 2023
@masatake
Copy link
Member Author

As I was afraid, this is not useful for real-world use cases.

@masatake masatake reopened this Dec 25, 2023
@masatake masatake force-pushed the I18NRubyGem branch 3 times, most recently from 6f5cc47 to 6f333c1 Compare December 26, 2023 19:47
@masatake
Copy link
Member Author

@akemrir, can I ask you to review the new man page again? 6f333c1

@masatake
Copy link
Member Author

masatake commented Dec 26, 2023 •
edited
Loading

@akemrir After I get an ack about the man page from you, I will merge this (with some modifications about 83eb3d3).

Updated. See 6f333c1 .

@masatake
main,refactor: lift up vStringAccumulate to the main part
90dd737 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
main,refactor: add vStringPutUnlessEmpty, vStringJoin, and vStringJoinS
4d7d892 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
Vera,refactor: use vStringJoin
137d800 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
YAML: wrap the code for debugging with #ifdef DEBUG/#endif
278f279 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
YAML: pass the current yamlSubparser to tagYpathTable::initTagEntry
1876f2c 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
YAML: accept any keywords in ypathStateStackMatch() if the expectatio…
da86b76 
…n is '*'

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
main,refactor: add copyExtraDynamic as a helper function
f991bad 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
main,comment: add comment to tagEntryInfo::placeholder
c50d11f 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
main: add resetTagCorkState
7bb113e 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
I18nRubyGem: new parser
98129c0 
Close universal-ctags#3523

Designed with Karol Jakusz-Gostomski <Karol Jakusz-Gostomski>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
docs(man): add a page for I18nRubyGem
bc3aa34 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake
Copy link
Member Author

I could not get an ack but I will merge this for releasing 6.1.

@masatake masatake merged commit a8513a0 into universal-ctags:master Dec 27, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akemrir akemrir akemrir left review comments

Assignees
No one assigned
Labels
next-release
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

YAML: extract keys (with scope) for I18n Ruby Gem
2 participants
@masatake @akemrir