Fix calls to ctype functions #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All ctype functions like `isdigit()` and alike expect a character as an `unsigned char` or EOF, anything else has undefined behavior. This commit should fix all calls to the various ctype functions either: * adding `unsigned char` cast where appropriate; * removing useless `int` casts that are more confusing than useful. Some instances required slightly more involved changes though, but the fix itself is the same. To find the calls to check, I used an equivalent to the following: ``` git grep -P 'is(alnum|alpha|cntrl|x?digit|graph|lower|print|punct|'\ 'space|upper|ascii|blank)|to(low|up)er' ``` ...and then proceeded to manually check them to see if the call, or call chain, was using appropriate values and types.
masatake
approved these changes
May 25, 2023
|
Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All ctype functions like
isdigit()and alike expect a character as anunsigned charor EOF, anything else has undefined behavior.This commit should fix all calls to the various ctype functions either:
unsigned charcast where appropriate;intcasts that are more confusing than useful.Some instances required slightly more involved changes though, but the fix itself is the same.
To find the calls to check, I used an equivalent to the following:
...and then proceeded to manually check them to see if the call, or call chain, was using appropriate values and types.
See also universal-ctags/ctags#3734