Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint plugin ember alpha v12 testing #209

Merged
merged 4 commits into from
Jan 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs-app/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,19 @@ module.exports = {
...config,
overrides: [
...config.overrides,
{
files: ['**/*.gts'],
plugins: ['ember'],
parser: 'ember-eslint-parser',
},
{
files: ['**/*.gjs'],
plugins: ['ember'],
parser: 'ember-eslint-parser',
},
{
files: ['**/*.ts', '**/*.gts'],
rules: {
'@typescript-eslint/prefer-optional-chain': 'off',
'@typescript-eslint/no-explicit-any': 'off',
},
},
Expand Down
12 changes: 8 additions & 4 deletions ember-primitives/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ module.exports = {
overrides: [
...config.overrides,
{
files: ['**/*.ts', '**/*.gts'],
rules: {
'@typescript-eslint/prefer-optional-chain': 'off',
},
files: ['**/*.gts'],
plugins: ['ember'],
parser: 'ember-eslint-parser',
},
{
files: ['**/*.gjs'],
plugins: ['ember'],
parser: 'ember-eslint-parser',
},
],
};
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@
},
"pnpm": {
"overrides": {
"@glimmer/validator": "^0.84.2",
"@glimmer/interfaces": "^0.84.2",
"@glimmer/validator": ">= 0.84.2",
"@glimmer/interfaces": ">= 0.84.2",
"ember-eslint-parser": "0.2.5",
"eslint-plugin-ember": "github:ember-cli/eslint-plugin-ember#master",
"ember-async-data": "1.0.1",
"ember-compatibility-helpers": "1.2.7",
"ember-cli-babel": "^8.2.0"
Expand Down
221 changes: 114 additions & 107 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

11 changes: 10 additions & 1 deletion test-app/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ module.exports = {
...config,
overrides: [
...config.overrides,
{
files: ['**/*.gts'],
plugins: ['ember'],
parser: 'ember-eslint-parser',
},
{
files: ['**/*.gjs'],
plugins: ['ember'],
parser: 'ember-eslint-parser',
},
{
files: ['tests/**/*'],
rules: {
Expand All @@ -18,7 +28,6 @@ module.exports = {
{
files: ['**/*.ts', '**/*.gts'],
rules: {
'@typescript-eslint/prefer-optional-chain': 'off',
'@typescript-eslint/no-explicit-any': 'off',
},
},
Expand Down
1 change: 1 addition & 0 deletions test-app/tests/dialog/dialog-rendering-test.gts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* global out */
import { tracked } from '@glimmer/tracking';
import { on } from '@ember/modifier';
import { click, find, render, settled } from '@ember/test-helpers';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* global out */
import { assert as debugAssert } from '@ember/debug';
import {
fillIn,
Expand Down
1 change: 1 addition & 0 deletions test-app/tests/one-time-password/otp-rendering-test.gts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* global out */
import { click, find, render } from '@ember/test-helpers';
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
Expand Down
Loading