-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember 5.6+ causes tracking issues #110
Comments
Oh I see the tests are passing on ember 5.8 now! nice. I will consume next update when published and see if my issue is resolved, otherwise I'll write up a failing test that targets the behaviour I am seeing. Thanks! |
Gonna re-open this as I didn't actually debug it, and the 5.6 to 5.8 changes shouldn't be affectiing reactiveweb -- however -- the VM did get upgraded in 5.6, and reactivity did get more strict about what you're allowed to do.
what updates abc? |
These are all wrapped in a class, I set something in a constructor. Wonder if that's got something to do with it? class LessonActivity {
lesson: number
constructor(lesson: number) {
// setOwner(...) etc
this.lesson = lesson
}
abc = trackedFunction(this, async () => {
const items = await getItems(this.lesson)
...
} and the template would look something like this openLesson = () => {
this.lessonActivity = new LessonActivity(1)
}
<template>
...
{{each this.lessonActivity.currentManifestBundle as ||}}
...
</template> |
Is lesson activity tracked? |
Yeah it is. I can try to create a failing test if nothing obvious is coming to mind |
Yeah, nothing obvious is jumping out at me. A failing test pr would be wonderful! |
Put together this test case which closely matches what I am aiming to do, though it is succeeding 😅 #115 Back to the drawing board. I'm going to try copying that test case over into my application and see if it fails/succeeds there under ember 5.8 |
thanks for your efforts!!! |
Managed to get the test to fail! Commented on that failing test PR, it's something to do with modifiers consuming the tracked-function before other things. |
I think also, @wycats identified a bug in ember-source 5.6+, so that's probably what you're running in to here -- my hope is that once the fix lands (and is backported) your failing test will no longer be failing |
Hello!
I recently started hitting some strange tracking issues with a combination of trackedFunctions and getters. The behaviour I noticed was;
This gives an idea of what I have. The example is contrived but it represents how my code is structured
From what I can tell, it is to do with ember-source - 5.4.1 works, 5.6 does not (nor does 5.8).
I've put together this failing PR that might help #109
The text was updated successfully, but these errors were encountered: