Rebuild dev image #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ev image to account for base image update.
|
Seems fine, have literally never used that command ;-) |
singularo
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Looks fine, might want to remove the CONFIG_SYNC thing as per:
https://gitlab.adelaide.edu.au/web-team/ua-wcms-foundation/merge_requests/198#note_90992 as well.
|
CONFIG_SYNC_DIRECTORY is used in RoboFileBase... |
|
@singularo how have you never used that command? 😕 |
|
Easy! Done ;-) And let it do its thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./dsh pull errored because it doesn't respect built local images - docker/compose#3660
Also, even when the base web image updates, a build doesn't occur - maybe we don't need this because in all likelihood you would dsh purge and rebuild when you bring it up again.