Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds black to dev-deps and runs it through poetry #32

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

colindean
Copy link
Contributor

Description

Previously, the Makefile depended on black being installed in the active
Python venv already. This instead lets Poetry manage it, lets the
lockfile determine the version, and has the Makefile run it via Poetry.

Type of changes

  • Adds dev dependency
  • Use that dependency's installed binary in Makefile

Checklist

  • All new and existing tests pass.
  • Any added/updated scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh and #!/bin/bash are allowed exceptions)
  • Added/updated scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No end-user should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that the link(s) in my PR are valid.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

Previously, the Makefile depended on black being installed in the active
Python venv already. This instead lets Poetry manage it, lets the
lockfile determine the version, and has the Makefile run it via Poetry.

Signed-off-by: Colin Dean <colin.dean@target.com>
@unixorn unixorn merged commit 0fe054f into unixorn:main Jun 3, 2022
@colindean colindean deleted the add-black-to-dev-deps branch June 3, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants