Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove extra await in spinner example #211

Merged
merged 1 commit into from
Jul 3, 2023
Merged

chore: remove extra await in spinner example #211

merged 1 commit into from
Jul 3, 2023

Conversation

Barbapapazes
Copy link
Member

start or success does not return a promise.

@pi0 pi0 changed the title docs: remove await in spinner.ts chore: remove await in spinner.ts example Jul 3, 2023
@pi0 pi0 changed the title chore: remove await in spinner.ts example chore: remove extra await in spinner example Jul 3, 2023
pi0
pi0 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit fa9c01c into unjs:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barbapapazes @pi0