Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formatTree): support max depth #267

Merged
merged 7 commits into from
Dec 19, 2024
Merged

feat(formatTree): support max depth #267

merged 7 commits into from
Dec 19, 2024

Conversation

Plumbiu
Copy link
Contributor

@Plumbiu Plumbiu commented Dec 14, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR is add max depth for formatTree:

console.log(formatTree(tree, {  depth: 2 }))
console.log(formatTree(tree, {
  depth: 2,
  ellipsis: '---',
}))

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

src/utils/tree.ts Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit 0183abc into unjs:main Dec 19, 2024
2 checks passed
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 95 lines in your changes missing coverage. Please review.

Project coverage is 20.80%. Comparing base (24c98ce) to head (406fdeb).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
examples/tree.ts 0.00% 79 Missing ⚠️
src/utils/tree.ts 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #267       +/-   ##
===========================================
- Coverage   61.08%   20.80%   -40.29%     
===========================================
  Files          13       43       +30     
  Lines        1380     2317      +937     
  Branches       58       88       +30     
===========================================
- Hits          843      482      -361     
- Misses        537     1807     +1270     
- Partials        0       28       +28     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants