Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not serailize binary messages #39

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Conversation

alexzhang1030
Copy link
Contributor

@alexzhang1030 alexzhang1030 commented May 15, 2024

πŸ”— Linked issue

related to #37

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Vahelnir
Copy link

Vahelnir commented May 18, 2024

Hey,
Not sure if you finished working on this PR yet, but I just wanted to let you know that, even though this PR looks necessary in order to fix #37, it doesn't fix it.
You might not want to close the issue with this PR :/

It should be easy to "fix", so I might propose a PR once I know it should be fixed in crossws (I was waiting for the maintainers' feedback on my issue before doing any work).

Thanks for your work !

src/_utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pi0 pi0 merged commit 2aea77c into unjs:main Jul 31, 2024
2 checks passed
@alexzhang1030 alexzhang1030 deleted the fix/buffer branch August 1, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants