feat: global publish #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying crossws with
|
| Latest commit: |
1ba7908
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82ee1094.crossws.pages.dev |
| Branch Preview URL: | https://feat-adapter-publish.crossws.pages.dev |
|
@pi0 Can you please publish this to npm? The last release was half a year ago. |
rossinek
reviewed
Oct 16, 2024
| publish(topic: string, message: any, options) { | ||
| const firstPeer = peers.values().next().value as Peer; | ||
| if (firstPeer) { | ||
| firstPeer.send(message, options); |
There was a problem hiding this comment.
Hi @pi0, thank you for this feature 🥇
I was about to use it although I think there is a bug here. You are publishing to firstPeer without checking whether it is subscribed to a topic.
I don't think there is currently an easy way to see which topics a peer is subscribed to without checking the protected property _topics, but temporary solution for me was to just do:
if (firstPeer['_topics'].has(topic)) firstPeer.send(message, options);BTW. I wish Nitro would expose these utils somewhere (I couldn't find any way to access them from Nuxt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29
Based on new feature in #60 with peers being accessible globally, we can pick the first one to publish to all other peers.
Note: There seems to be a limitation with cloudflare that is not possible for it. In most cases, i would recommend to directly use peer itself to broadcast as it runs within the right context.
Cloudflare error: