feat: support for throwables #91
Open
+130
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iformly across adapters.
|
Seems nice direction! It might take me little longer to jump on proper review. |
|
@pi0 Any chance you may be able to take a look at this PR soon? |
|
@pi0 Circling back around on this, I see these changes as a pseudo-prerequisite for getting Web Sockets added to SvelteKit. I'm happy to work on any changes or feedback that needs to be incorporated and would love to get tests running if some exist. |
|
@pi0 Can you assist with the logic around the errors? I see that the tests expect ws.Error to be populated on unauthorized response, how is that properly set cross platform? |
|
Of course. Applogizes again for delay. I will directly check tests and changes ASAP to move it forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should introduce support for throwing for errors or returning for success from the upgrade handler, all the interfacing with the adapters should remain the same.