Skip to content

Commit

Permalink
fix: throw wrapped error with legacy middleware
Browse files Browse the repository at this point in the history
  • Loading branch information
pi0 committed Apr 1, 2022
1 parent 5e86d0c commit 27e9477
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 2 additions & 1 deletion src/handler.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { withoutTrailingSlash, withoutBase } from 'ufo'
import { createError } from './error'
import type { Handler, PromisifiedHandler, Middleware, IncomingMessage, ServerResponse, LazyHandler } from './types'

export const defineHandler = <T>(handler: Handler<T>) => handler
Expand All @@ -25,7 +26,7 @@ export function callHandler (handler: Middleware, req: IncomingMessage, res: Ser
res.off('close', next)
res.off('error', next)
}
return err ? reject(err) : resolve(undefined)
return err ? reject(createError(err)) : resolve(undefined)
}
try {
const returned = handler(req, res, next)
Expand Down
3 changes: 0 additions & 3 deletions test/error.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ describe('error', () => {
const result = await request.get('/api/test')

expect(result.status).toBe(500)
// eslint-disable-next-line
expect(console.error).toBeCalled()

expect(JSON.parse(result.text)).toMatchObject({
statusCode: 500,
statusMessage: 'H3Error'
Expand Down

0 comments on commit 27e9477

Please sign in to comment.