Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetchWithEvent): allow customizing fetch impl type #414

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 23, 2023

Downstream we are wrongly typing event.$fetch. This is part of the fix.

@danielroe danielroe requested a review from pi0 June 23, 2023 23:44
@danielroe danielroe self-assigned this Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #414 (e6a2a10) into main (33f434f) will decrease coverage by 0.07%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   76.51%   76.44%   -0.07%     
==========================================
  Files          26       26              
  Lines        2491     2501      +10     
  Branches      355      355              
==========================================
+ Hits         1906     1912       +6     
- Misses        585      589       +4     
Impacted Files Coverage Δ
src/utils/proxy.ts 81.73% <25.00%> (-1.61%) ⬇️
src/error.ts 78.23% <94.11%> (+0.79%) ⬆️

src/utils/proxy.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix: allow passing alternative fetcher implementations fix(fetchWithEvent): allow customizing fetch impl type Jun 26, 2023
@danielroe danielroe force-pushed the fix/event-fetch-generic branch from 30dc262 to e6a2a10 Compare June 27, 2023 10:35
@pi0 pi0 merged commit 7b5d4df into main Jun 28, 2023
@pi0 pi0 deleted the fix/event-fetch-generic branch June 28, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants