-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support blob responses #422
Conversation
Would you please add a unit test? 🙏🏼 |
Well during writing tests I realized the real issue was that Blob type was not being handled properly, which was why the fix was working, So I handled it in |
I have pushed a commit to fix the lint issues but I don't the commit in the PR, what am I doing wrong ? is it me or github being funny ? |
yeah it was GitHub, re-set the base branch on edit dialog and it showed up |
@jd1378 This is a very good change, thanks for adding the tests ! |
Codecov Report
@@ Coverage Diff @@
## main #422 +/- ##
==========================================
+ Coverage 77.18% 77.22% +0.04%
==========================================
Files 26 26
Lines 2608 2613 +5
Branches 377 379 +2
==========================================
+ Hits 2013 2018 +5
Misses 595 595
|
pushed commit for both suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️
Resolves #385 and nitrojs/nitro#1237