Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add removeResponseHeader and clearResponseHeaders utils #427

Merged
merged 10 commits into from
Jul 26, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Jul 6, 2023

  • feat: add request and response helpers
  • feat: add url utilities

πŸ”— Linked issue

#420
#423

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds 7 new helpers.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Hebilicious Hebilicious force-pushed the missing-helpers-lean branch from 3fed272 to ae267f6 Compare July 6, 2023 14:21
@Hebilicious Hebilicious changed the title missing helpers lean feat: add missing response and request helpers Jul 6, 2023
@Hebilicious Hebilicious requested a review from pi0 July 6, 2023 15:27
@Hebilicious Hebilicious added enhancement New feature or request helpers ready labels Jul 6, 2023
src/utils/request.ts Outdated Show resolved Hide resolved
src/utils/request.ts Outdated Show resolved Hide resolved
src/utils/request.ts Outdated Show resolved Hide resolved
@pi0 pi0 marked this pull request as draft July 10, 2023 12:46
@pi0 pi0 changed the title feat: add missing response and request helpers feat: add helpers to reduce dependency on event.node.* Jul 10, 2023
@Hebilicious Hebilicious force-pushed the missing-helpers-lean branch from 459841b to 99ece01 Compare July 10, 2023 14:42
@Hebilicious Hebilicious force-pushed the missing-helpers-lean branch from 99ece01 to fbc7501 Compare July 25, 2023 06:57
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #427 (37448b3) into main (7764b99) will increase coverage by 0.71%.
Report is 2 commits behind head on main.
The diff coverage is 97.59%.

❗ Current head 37448b3 differs from pull request most recent head 1b09440. Consider uploading reports for the commit 1b09440 to get more accurate results

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   78.52%   79.24%   +0.71%     
==========================================
  Files          26       27       +1     
  Lines        2841     2924      +83     
  Branches      417      436      +19     
==========================================
+ Hits         2231     2317      +86     
+ Misses        610      607       -3     
Files Changed Coverage Ξ”
src/utils/internal/validate.ts 94.44% <94.44%> (ΓΈ)
src/types.ts 100.00% <100.00%> (ΓΈ)
src/utils/body.ts 95.36% <100.00%> (+0.22%) ⬆️
src/utils/request.ts 98.55% <100.00%> (+0.10%) ⬆️
src/utils/response.ts 73.17% <100.00%> (+3.43%) ⬆️

... and 1 file with indirect coverage changes

@Hebilicious Hebilicious marked this pull request as ready for review July 25, 2023 06:57
@Hebilicious Hebilicious requested a review from pi0 July 25, 2023 06:57
@pi0 pi0 changed the title feat: add helpers to reduce dependency on event.node.* feat: add removeResponseHeader and removeResponseHeaders utils Jul 25, 2023
src/utils/response.ts Outdated Show resolved Hide resolved
@Hebilicious Hebilicious requested a review from pi0 July 26, 2023 06:27
@pi0 pi0 changed the title feat: add removeResponseHeader and removeResponseHeaders utils feat: add removeResponseHeader and clearResponseHeaders utils Jul 26, 2023
@pi0 pi0 merged commit 29445c4 into main Jul 26, 2023
@pi0 pi0 deleted the missing-helpers-lean branch July 26, 2023 17:47
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helpers ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants