Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event): do not remove double slashes from query #462

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

Aareksio
Copy link
Contributor

@Aareksio Aareksio commented Jul 26, 2023

πŸ”— Linked issue

#463
(also see added test case)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently the regex replaces all occurrences of multiple / with a single /. This is desired, but only for the path, not query part of the URL. This PR ensures the replacement is only done to the part of path coming before ?. There is no ufo helper for extracting just the path nor for detecting if path includes query - therefore I have used good old .includes('?') and .split('?').

There is cleanDoubleSlashes available in ufo, but it seems to suffer from the same issue. May be worth fixing there and updating h3 to use ufo helper.

Resolves #463

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit ac626c4 into unjs:main Jul 26, 2023
@pi0
Copy link
Member

pi0 commented Jul 26, 2023

There is cleanDoubleSlashes available in ufo, but it seems to suffer from the same issue. May be worth fixing there and updating h3 to use ufo helper.

Upstream PR welcome for ufo too πŸ’―

@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event.path is being parsed incorrectly
2 participants