Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): extract handler returned response handling #473

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 31, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is an internal refactor to make future implementation changes easier for handling values directly returned in event handler as response.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #473 (db94d67) into main (06d1bc1) will increase coverage by 0.07%.
The diff coverage is 94.91%.

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   79.77%   79.85%   +0.07%     
==========================================
  Files          27       27              
  Lines        2987     2993       +6     
  Branches      441      445       +4     
==========================================
+ Hits         2383     2390       +7     
+ Misses        604      603       -1     
Files Changed Coverage Ξ”
src/app.ts 96.52% <94.91%> (-1.25%) ⬇️

... and 1 file with indirect coverage changes

@pi0 pi0 merged commit f5a5d6b into main Aug 1, 2023
@pi0 pi0 deleted the refactor/app-response-handler branch August 1, 2023 10:29
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant