Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getRequestProtocol): conditionaly check connection?.encrypted #532

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

michealroberts
Copy link
Contributor

fix: add optional chain (.?) to event connection check in getRequestProtocol

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

A minor change, but essentially if event.node.req.connection is undefined ... we can't check for the encrypted boolean value, therefore an optional chain has been added.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

…getRequestProtocol

fix: Added optional chain (.?) to event.node.req.connection check in getRequestProtocol
@pi0 pi0 changed the title fix: add optional chain (.?) to event connection check in getRequestProtocol fix(getRequestProtocol): conditionaly check connection?.encrypted Sep 26, 2023
@pi0 pi0 merged commit 9427e18 into unjs:main Sep 26, 2023
4 checks passed
@pi0
Copy link
Member

pi0 commented Sep 26, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants