Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getRequestIP): use first address of x-forwarded-for header #618

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 16, 2024

πŸ”— Linked issue

resolves #588

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (4475b74) 77.79% compared to head (e7ebf94) 77.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   77.79%   77.80%   +0.01%     
==========================================
  Files          47       47              
  Lines        4279     4281       +2     
  Branches      609      610       +1     
==========================================
+ Hits         3329     3331       +2     
  Misses        933      933              
  Partials       17       17              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2024

Deploying with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: e7ebf94
Status:🚫  Build failed.

View logs

@pi0 pi0 merged commit 569c245 into main Jan 16, 2024
6 of 7 checks passed
@pi0 pi0 deleted the fix/xforwarded branch January 16, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getRequestIP returns the last IP address in the X-Forwarded-For header
1 participant