Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readRawBody): handle URLSearchParams #888

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix(readRawBody): handle URLSearchParams #888

merged 3 commits into from
Oct 3, 2024

Conversation

phoenix-ru
Copy link

resolves #887

@alimozdemir

This comment was marked as off-topic.

@julienguillot77

This comment was marked as off-topic.

@pi0 pi0 changed the title fix(#887): handle URLSearchParams case in readRawBody fix(readRawBody): handle URLSearchParams Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (v1@19b975d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/utils/body.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v1     #888   +/-   ##
=====================================
  Coverage      ?   71.46%           
=====================================
  Files         ?       58           
  Lines         ?     3228           
  Branches      ?      699           
=====================================
  Hits          ?     2307           
  Misses        ?      902           
  Partials      ?       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 merged commit 011e2cf into unjs:v1 Oct 3, 2024
5 checks passed
@pi0
Copy link
Member

pi0 commented Oct 3, 2024

Thanks. I added a TODO, we might handle other valid bodyinit types also in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants