Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(withBase): update with pathname instead of path #912

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gulshan
Copy link

@gulshan gulshan commented Nov 10, 2024

resolves #878

@gulshan gulshan requested a review from pi0 as a code owner November 10, 2024 04:42
@pi0 pi0 changed the title Update pathname instead of path in withBase fix(withBase): update with pathname instead of path Nov 12, 2024
@pi0
Copy link
Member

pi0 commented Nov 12, 2024

Can you please add a test as well? 🙏🏼

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (a58d7c9) to head (a96acfa).
Report is 188 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
+ Coverage   77.83%   79.45%   +1.61%     
==========================================
  Files          47       43       -4     
  Lines        4286     3290     -996     
  Branches      611      795     +184     
==========================================
- Hits         3336     2614     -722     
+ Misses        933      673     -260     
+ Partials       17        3      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gulshan
Copy link
Author

gulshan commented Nov 13, 2024

@pi0 The issue was only happening with toNodeHandler and most probably tied to how the pathname property is set in NodeReqURLProxy. But I put the fix in the common code. So, I am a bit confuse about how I should test it.

@gulshan
Copy link
Author

gulshan commented Nov 26, 2024

@pi0 Tried adding an integration test. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event.url.pathname is updated incorrectly in withBase method for NodeEvents
2 participants