Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #919

Merged
merged 4 commits into from
Nov 25, 2024
Merged

docs: fix typos #919

merged 4 commits into from
Nov 25, 2024

Conversation

danielrentz
Copy link
Contributor

Typos

@nozomuikuta nozomuikuta changed the title docs: Update 1.request.md docs: fix typos Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1@3dd17c2). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v1     #919   +/-   ##
=====================================
  Coverage      ?   71.33%           
=====================================
  Files         ?       59           
  Lines         ?     3234           
  Branches      ?      700           
=====================================
  Hits          ?     2307           
  Misses        ?      907           
  Partials      ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@nozomuikuta nozomuikuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielrentz

The text you have fixed are auto-generated based on JSDoc, so that CI overwrited your fixes.

Would you fix JSDoc comments instead?

@danielrentz
Copy link
Contributor Author

danielrentz commented Nov 25, 2024

Oh right I missed that. Will do the changes in source code.

@danielrentz danielrentz mentioned this pull request Nov 25, 2024
Copy link
Member

@nozomuikuta nozomuikuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nozomuikuta nozomuikuta merged commit e89e91a into unjs:v1 Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants