-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optional access to Reflect.metadata
#165
Conversation
Thanks for this PR i really appreciate it. Before moving forward with adding a fork, have you considered to make an upstream PR directly to babel? Also in the meantime, would be nice if we inline the forked version of patch in jiti codebase (same as other plugin forks) but better maintainability. Adding tests to the fixtures would be also awesome! |
I already did this (leonardfactory/babel-plugin-transform-typescript-metadata#70) over a month ago the last activity in this repository was on March 4, 2022 |
We can move this repo to the |
Moving to |
Do you recommend moving all the code to |
Source data only yes. (there are too many repos to maintain in unjs already and i hope we don't need constant update for this until your PR lands upstream -- hopefully) |
905de19
to
b03cf3f
Compare
One remark, there is a problem with pnpm, I suspect that it is install the types incorrectly |
Ok, I just hate pnpm lock, it's ok now |
@pi0 what do you think about it now? |
Thanks for the updates! Will check it soon locally ππΌ |
@pi0 hi, how's your check going? |
Reflect.metadata
π Linked issue
#145
β Type of change
replace
babel-plugin-transform-typescript-metadata
π Description
Replace all call Reflect.metadata with optional call (if not install
reflect-metadata
)π Checklist