Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eval esm modules with fallback loader #300

Merged
merged 3 commits into from
Sep 25, 2024
Merged

feat: eval esm modules with fallback loader #300

merged 3 commits into from
Sep 25, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 25, 2024

Resolves #167

In the async context (jiti.import), we can use an alternative ESM loader using dynamic imports which is slower but increases compatibility.

(Alternatively we could directly import from cache result but it needs edge-case handling for when case is disabled and HMR support will be lost too)

@pi0 pi0 self-assigned this Sep 25, 2024
@pi0
Copy link
Member Author

pi0 commented Sep 25, 2024

/cc @antfu :D

@pi0 pi0 merged commit a59ed9f into main Sep 25, 2024
7 checks passed
@pi0 pi0 deleted the feat/fallback branch September 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support arbitrary import.meta.* syntax (vitest insource testing)
1 participant