Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support import.meta.dirname and import.meta.filename #308

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

aryaemami59
Copy link
Contributor

This PR:

This is just the initial implementation. I would still like to figure out a way to get import.meta.dirname === __dirname, though it seems like the issue is coming from __dirname and the fact that it is injected with forward slashes which is not correct.

@aryaemami59 aryaemami59 force-pushed the add-import-meta-dirname branch 2 times, most recently from bab375e to e6c966d Compare September 26, 2024 17:59
@aryaemami59 aryaemami59 marked this pull request as ready for review September 26, 2024 17:59
@aryaemami59 aryaemami59 force-pushed the add-import-meta-dirname branch 2 times, most recently from a13d2a7 to d56fd4a Compare September 26, 2024 18:07
@aryaemami59 aryaemami59 force-pushed the add-import-meta-dirname branch from d56fd4a to f293e64 Compare September 26, 2024 18:10
@aryaemami59
Copy link
Contributor Author

Alright just had to get CI to be nice. It should be good to go now.

@pi0 pi0 changed the title feat: Add support for import.meta.dirname and import.meta.filename feat: support import.meta.dirname and import.meta.filename Sep 30, 2024
@pi0 pi0 merged commit 35ddef7 into unjs:main Sep 30, 2024
7 checks passed
@aryaemami59 aryaemami59 deleted the add-import-meta-dirname branch October 1, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add import.meta.dirname and import.meta.filename
2 participants