Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analyze): ignore conmments for imports detection #155

Merged
merged 6 commits into from
Jan 11, 2024
Merged

fix(analyze): ignore conmments for imports detection #155

merged 6 commits into from
Jan 11, 2024

Conversation

lishaobos
Copy link
Contributor

@lishaobos lishaobos commented Mar 1, 2023 •
edited by atinux
Loading

pi0
pi0 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pi0 pi0 requested review from antfu and danielroe March 1, 2023 10:03
danielroe
danielroe reviewed Mar 1, 2023
View reviewed changes
src/_utils.ts Outdated Show resolved Hide resolved
@lishaobos lishaobos requested review from danielroe and antfu and removed request for antfu and danielroe March 11, 2023 08:28
@lishaobos
Copy link
Contributor Author

sorry, i forgot the code format.

@lishaobos
Copy link
Contributor Author

lishaobos commented Mar 11, 2023 •
edited
Loading

image

what happend? i alaways build successed and i can not find these word in the code.

image
image
image

@lishaobos
Copy link
Contributor Author

it is branch not right? 😄😄😄

@lishaobos
Copy link
Contributor Author

lishaobos commented Mar 13, 2023 •
edited
Loading

@danielroe hi, i fixed it. it is actions merge error.

https://github.com/unjs/mlly/actions/runs/4392442503/jobs/7692420749#step:2:204

image

@lishaobos lishaobos requested review from danielroe and removed request for antfu March 13, 2023 06:07
@danielroe danielroe requested a review from antfu March 13, 2023 16:48
@codecov
Copy link

codecov bot commented Mar 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c29618f) 86.86% compared to head (fe63e14) 86.96%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   86.86%   86.96%   +0.10%     
==========================================
  Files           8        8              
  Lines        1028     1036       +8     
  Branches      168      168              
==========================================
+ Hits          893      901       +8     
  Misses        135      135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 added the pending label Jun 19, 2023
@pi0 pi0 self-requested a review June 19, 2023 13:55
@pi0 pi0 mentioned this pull request Jan 11, 2024
Merged
8 tasks
@pi0 pi0 changed the title fix: ignore match comments fix(analyze): ignore conmments for imports detection Jan 11, 2024
pi0
pi0 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work and refactors thanks 💯

@pi0 pi0 merged commit d212da8 into unjs:main Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe Awaiting requested review from danielroe

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

findStaticImports and findDynamicImports do not respect comments ref在.vue需要额外引入
4 participants
@lishaobos @pi0 @antfu @danielroe