fix: fix resolvePath return type
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 85.79% 85.89% +0.09%
==========================================
Files 8 8
Lines 859 865 +6
Branches 134 134
==========================================
+ Hits 737 743 +6
Misses 122 122
|
pi0
changed the title
resolvePath return type
pi0
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolvePathreturn type is being lost whenresolvePathSyncis passed topcall(Promise<any> instead of Promise<string>).resolvehas the same issue but its return type was being cast from Promise<any> to Promise<string> via the function signature. instead of casting any I updatedpcall's types to reflect what is happening which fixesresolvePathtypes to Promise<string>