Error building with cloudflare, vercel-edge or netlify-edge presets

[maoosi]

Environment

• Node.js v16.14.2
• Nuxt 3.0.0-rc.6
• Nitropack 0.4.12

Reproduction

Click here to access reproduction on Stackblitz, then run the below command:

# working as expected
npm run build

# build errors
NITRO_PRESET=cloudflare npm run build
NITRO_PRESET=vercel-edge npm run build
NITRO_PRESET=netlify-edge npm run build

Describe the bug

Nuxt3 build is failing when running with edge-related presets such as:

• NITRO_PRESET=cloudflare
• NITRO_PRESET=vercel-edge
• NITRO_PRESET=netlify-edge

Additional context

Probably related to:

• Error when building for cloudflare preset #280.
• Preset cloudflare not ignoring optional require() #293

Logs

Example logs when using NITRO_PRESET=cloudflare:

ERROR  Rollup error: Cannot resolve "/home/projects/nitro-preset-cloudflare-issue/node_modules/unenv/runtime/node/stream/index/web.cjs" from "/home/projects/nitro-preset-cloudflare-issue/node_modules/cross-undici-fetch/dist/create-node-ponyfill.js" and externals are not allowed!

ERROR  Cannot resolve "/home/projects/nitro-preset-cloudflare-issue/node_modules/unenv/runtime/node/stream/index/web.cjs" from "/home/projects/nitro-preset-cloudflare-issue/node_modules/cross-undici-fetch/dist/create-node-ponyfill.js" and externals are not allowed!

[warflash]

#293 is probably also be related. Seems like unfortunately the cloudflare preset is pretty dead at the moment

[maoosi]

I've edited my initial post to include #293. I also noticed the same issue with NITRO_PRESET=vercel-edge, so this issue is probably affecting all edge-related presets.

[warflash]

@maoosi Did you get a chance to verify the fix yet? I just updated my bridge app to nitro 0.4.18 and am still running into the same rollup externals not allowed error on edge presets. Wondering if I'm experiencing something unrelated or if the error still persists

---

For reference, this is the failing import part.
https://github.com/uber-web/probe.gl/blob/master/modules/log/src/node/node-asciify-image.ts
I suspect the try catch around the require might be throwing something off and due to edge targets not supporting the node runtime it crashes
@danielroe

[danielroe]

The original reproduction (linked above) is now succeeding: https://stackblitz.com/edit/nitro-preset-cloudflare-issue-yxjhpg. I can't speak to your project @warflash but you are welcome to open a new issue with a reproduction and I'll be very happy to look into it.

[warflash]

Oh right, I missed the repro link, sorry about that. Opened #410, thanks for taking a look! 💯