fix: order aliases from specific to general #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
We might normalize and sort them in |
danielroe
force-pushed
the
fix/alias-ordering
branch
from
41b18c7
to
dce9988
Compare
pi0
reviewed
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently aliases are resolved from top down, so
stream/webis (for example) resolved asunenv/runtime/node/stream/index/webrather thanunenv/runtime/node/stream/web/index.This PR reorders aliases so the more specific ones are at the top. Alternatively, we could use a helper function to do this for us.
unjs/nitro#378