Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: order aliases from specific to general #45

Merged
merged 3 commits into from
Aug 5, 2022
Merged

fix: order aliases from specific to general #45

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f57f57e
fix: order aliases from specific to general
danielroe Aug 5, 2022
dce9988
refactor: sort aliases once
danielroe Aug 5, 2022
c54d59f
perf: simplify!
danielroe Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ export function env (...presets: Preset[]): Environment {
for (const preset of presets) {
// Alias
if (preset.alias) {
for (const from in preset.alias) {
// Sort aliases from specific to general (ie. fs/promises before fs)
const aliases = Object.keys(preset.alias).sort((a, b) =>
b.split('/').length - a.split('/').length
danielroe marked this conversation as resolved.
Show resolved Hide resolved
)
for (const from of aliases) {
_env.alias[from] = preset.alias[from]
}
}
Expand Down