Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: workaround for describe.skipIf not working #1240

Merged
merged 3 commits into from
May 16, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 16, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Windows CI should skip vercel-edge but it is not skipping it with describe.skipIf(isWindows)(...) only in CI. (runIf seems broken too)

Failing: https://github.com/unjs/nitro/actions/runs/4989669099/jobs/8933890560#step:8:345

/cc @antfu

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #1240 (9d3fd02) into main (3073423) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   77.24%   76.95%   -0.30%     
==========================================
  Files          67       67              
  Lines        6712     6712              
  Branches      688      684       -4     
==========================================
- Hits         5185     5165      -20     
- Misses       1525     1546      +21     
+ Partials        2        1       -1     

see 3 files with indirect coverage changes

@pi0 pi0 marked this pull request as ready for review May 16, 2023 08:54
@pi0 pi0 changed the title chore: try to fix windows ci chore: workaround for describe.skipIf not working May 16, 2023
@pi0 pi0 merged commit 44bf0e7 into main May 16, 2023
@pi0 pi0 deleted the chore/test-describe-if branch May 16, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant