-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid doubly-bundling runtime types #1334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I am on phone trusting you already tested build)
Can you please check failing ci? |
Codecov Report
@@ Coverage Diff @@
## main #1334 +/- ##
==========================================
- Coverage 76.74% 76.64% -0.10%
==========================================
Files 71 70 -1
Lines 7181 7151 -30
Branches 710 710
==========================================
- Hits 5511 5481 -30
Misses 1669 1669
Partials 1 1
|
previewing this and #1333 in nuxt/nuxt#21683. we can confirm everything is passing before merging/releasing |
π Linked issue
β Type of change
π Description
At the moment we are bundling two copies of various runtime types, one in the main
nitropack
index.d.ts and another in the runtime directory. The danger with this is that types can get out of sync when extending one of those two.π Checklist