Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually merge runtime config with env #143

Merged
merged 2 commits into from
Apr 22, 2022
Merged

fix: manually merge runtime config with env #143

merged 2 commits into from
Apr 22, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 22, 2022

πŸ”— Linked issue

resolves #139, closes #140

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This reverts to an earlier version of the override configuration in #65.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 22, 2022
@danielroe danielroe requested a review from pi0 April 22, 2022 12:26
@danielroe danielroe self-assigned this Apr 22, 2022
@pi0 pi0 changed the title fix: use inlined overrideConfig fix: manually merge runtime config with env Apr 22, 2022
@pi0 pi0 merged commit 1be5ac2 into main Apr 22, 2022
@pi0 pi0 deleted the fix/override-config branch April 22, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtimeConfig array keys gets duplicated
2 participants