Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prerender): support for query links exploration #1474

Merged
merged 11 commits into from
Aug 7, 2023

Conversation

Velka-DEV
Copy link
Contributor

@Velka-DEV Velka-DEV commented Jul 21, 2023

πŸ”— Linked issue

#1473

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

What:

The pre-renderer process now explore query links found on the page (without rendering them as this could cause problem for OS that don't support such chars in the file path)

Why:

If for example posts links are present in paginated pages like https://example.com/posts?page=3, they will not be pre-rendered that could cause performance issues and also break some functionalities when modules rely on pre-rendering (such as sitemap)

Issue:

Resolves #1473

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Velka-DEV Velka-DEV changed the title feat: support for query links exploration fix(prerenderer): support for query links exploration Jul 21, 2023
@Velka-DEV Velka-DEV changed the title fix(prerenderer): support for query links exploration fix(prerender): support for query links exploration Jul 21, 2023
@pi0 pi0 changed the title fix(prerender): support for query links exploration feat(prerender): support for query links exploration Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1474 (5850697) into main (6669fb2) will decrease coverage by 0.31%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
- Coverage   76.40%   76.10%   -0.31%     
==========================================
  Files          73       73              
  Lines        7558     7570      +12     
  Branches      745      745              
==========================================
- Hits         5775     5761      -14     
- Misses       1782     1808      +26     
  Partials        1        1              
Files Changed Coverage Ξ”
src/prerender.ts 85.74% <89.47%> (+0.57%) ⬆️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

... and 2 files with indirect coverage changes

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit cd56e14 into unjs:main Aug 7, 2023
8 checks passed
@Velka-DEV
Copy link
Contributor Author

Thanks you a lot @pi0, great work done here. Will this fix be part of the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crawl links with query params without writing to the disk
3 participants