Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudflare): add queue and scheduled support WIP #1579

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 34 additions & 7 deletions src/runtime/entries/cloudflare-module.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
/* eslint-disable require-await */
import "#internal/nitro/virtual/polyfill";
import { withoutBase } from "ufo";
import type { ExecutionContext } from "@cloudflare/workers-types";
import type {
ExecutionContext as CFExecutionContext,
ExportedHandler,
Response as CFResponse,
} from "@cloudflare/workers-types";
import {
getAssetFromKV,
mapRequestToAsset,
Expand All @@ -9,6 +14,7 @@ import {
// See https://github.com/cloudflare/kv-asset-handler#asset_manifest-required-for-es-modules
import manifest from "__STATIC_CONTENT_MANIFEST";
import { requestHasBody } from "../utils";
import type { ExtendedExecutionContext } from "../types";
import { nitroApp } from "#internal/nitro/app";
import { useRuntimeConfig } from "#internal/nitro";
import { getPublicAssetMeta } from "#internal/nitro/virtual/public-assets";
Expand All @@ -17,12 +23,9 @@ interface CFModuleEnv {
[key: string]: any;
}

export default {
async fetch(
request: Request, // CFRequest,
env: CFModuleEnv,
context: ExecutionContext
) {
export default <ExportedHandler>{
async fetch(cfRequest, env: CFModuleEnv, context) {
const request = cfRequest as unknown as Request;
try {
// https://github.com/cloudflare/kv-asset-handler#es-modules
return await getAssetFromKV(
Expand Down Expand Up @@ -67,7 +70,31 @@ export default {
method: request.method,
headers: request.headers,
body,
}) as unknown as CFResponse;
},
// https://developers.cloudflare.com/queues/get-started/#5-create-your-consumer-worker
async queue(batch, env: CFModuleEnv, context: ExtendedExecutionContext) {
context.sendResponse = () => null;
await nitroApp.hooks.callHook("cloudflare-module:queue", {
batch,
env,
context,
});
return context.sendResponse();
},
// https://developers.cloudflare.com/workers/runtime-apis/scheduled-event/
async scheduled(
controller,
env: CFModuleEnv,
context: ExtendedExecutionContext
) {
context.sendResponse = () => null;
await nitroApp.hooks.callHook("cloudflare-module:scheduled", {
controller,
env,
context,
});
return context.sendResponse();
},
};

Expand Down
30 changes: 28 additions & 2 deletions src/runtime/entries/cloudflare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,40 @@ import {
getAssetFromKV,
mapRequestToAsset,
} from "@cloudflare/kv-asset-handler";
import type {
WorkerGlobalScopeEventMap,
EventListenerOrEventListenerObject,
EventTargetAddEventListenerOptions,
Response as CFResponse,
} from "@cloudflare/workers-types";
import { withoutBase } from "ufo";
import { requestHasBody } from "../utils";
import { nitroApp } from "#internal/nitro/app";
import { useRuntimeConfig } from "#internal/nitro";
import { getPublicAssetMeta } from "#internal/nitro/virtual/public-assets";

addEventListener("fetch", (event: any) => {
event.respondWith(handleEvent(event));
declare function addEventListener<Type extends keyof WorkerGlobalScopeEventMap>(
type: Type,
handler: EventListenerOrEventListenerObject<WorkerGlobalScopeEventMap[Type]>,
options?: EventTargetAddEventListenerOptions | boolean
): void;

// https://developers.cloudflare.com/workers/runtime-apis/add-event-listener
// https://developers.cloudflare.com/workers/runtime-apis/scheduled-event/
addEventListener("scheduled", async (event) => {
await nitroApp.hooks.callHook("cloudflare:scheduled", event);
});

// https://developers.cloudflare.com/workers/runtime-apis/add-event-listener
// https://developers.cloudflare.com/queues/platform/javascript-apis/#consumer
addEventListener("queue", async (event) => {
await nitroApp.hooks.callHook("cloudflare:queue", event);
});

addEventListener("fetch", (event) => {
event.respondWith(
handleEvent(event as unknown as FetchEvent) as unknown as CFResponse
);
});

async function handleEvent(event: FetchEvent) {
Expand Down
39 changes: 39 additions & 0 deletions src/runtime/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
import {
ScheduledEvent,
ExecutionContext,
MessageBatch,
QueueEvent,
ScheduledController,
} from "@cloudflare/workers-types";
import type { H3Event, AppOptions } from "h3";
import type { RenderResponse } from "./renderer";

Expand All @@ -21,6 +28,32 @@ export type CaptureError = (
context: CapturedErrorContext
) => void;

interface CloudflareModuleEnv {
[key: string]: any;
}

type SendResponse = { sendResponse: () => any };

export type ExtendedExecutionContext = ExecutionContext & SendResponse;

interface CloudflareModuleRuntimeHooks {
"cloudflare:scheduled": (e: {
controller: ScheduledController;
env: CloudflareModuleEnv;
context: ExtendedExecutionContext;
}) => any;
"cloudflare:queue": (e: {
batch: MessageBatch;
env: CloudflareModuleEnv;
context: ExtendedExecutionContext;
}) => any;
}

interface CloudflareSWRuntimeHooks {
"cloudflare:scheduled": (event: ScheduledEvent) => any;
"cloudflare:queue": (event: QueueEvent) => any;
}

export interface NitroRuntimeHooks {
close: () => void;
error: CaptureError;
Expand All @@ -29,6 +62,12 @@ export interface NitroRuntimeHooks {
beforeResponse: AppOptions["onBeforeResponse"];
afterResponse: AppOptions["onAfterResponse"];

"cloudflare-module:scheduled": CloudflareModuleRuntimeHooks["cloudflare:scheduled"];
"cloudflare-module:queue": CloudflareModuleRuntimeHooks["cloudflare:queue"];

"cloudflare:scheduled": CloudflareSWRuntimeHooks["cloudflare:scheduled"];
"cloudflare:queue": CloudflareSWRuntimeHooks["cloudflare:queue"];

"render:response": (
response: Partial<RenderResponse>,
context: { event: H3Event }
Expand Down
33 changes: 33 additions & 0 deletions test/fixture/plugins/hooks.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { defineNitroPlugin } from "../../../src/runtime/plugin";

export default defineNitroPlugin((app) => {
app.hooks.hook("cloudflare:scheduled", (event) => {
console.log("SCHEDULED", event, event.scheduledTime, event.cron);
event.waitUntil(Promise.resolve(0));
event.waitUntil(Promise.resolve(event.scheduledTime));
event.waitUntil(Promise.resolve(event.cron));
event.waitUntil(Promise.resolve("scheduled:cloudflare"));
});

app.hooks.hook(
"cloudflare-module:scheduled",
({ controller, env, context }) => {
console.log(
"SCHEDULED:M",
controller,
controller.scheduledTime,
controller.cron
);
context.waitUntil(Promise.resolve(0));
context.waitUntil(Promise.resolve(controller.scheduledTime));
context.waitUntil(Promise.resolve(controller.cron));
context.sendResponse = () => "scheduled:cloudflare-module";
}
);

app.hooks.hook("cloudflare:queue", (event) => {});

app.hooks.hook("cloudflare-module:queue", ({ batch, env, context }) => {
context.sendResponse = () => "queued:cloudflare-module";
});
});
34 changes: 20 additions & 14 deletions test/presets/cloudflare-module.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,23 @@ import { setupTest, testNitro } from "../tests";
describe("nitro:preset:cloudflare-module", async () => {
const ctx = await setupTest("cloudflare-module");

testNitro(ctx, () => {
const mf = new Miniflare({
modules: true,
scriptPath: resolve(ctx.outDir, "server/index.mjs"),
sitePath: resolve(ctx.outDir, "public"),
bindings: {
ASSETS: {
fetch: async (request) => {
const contents = await fsp.readFile(
join(ctx.outDir, new URL(request.url).pathname)
);
return new _Response(contents);
},
const mf = new Miniflare({
modules: true,
scriptPath: resolve(ctx.outDir, "server/index.mjs"),
sitePath: resolve(ctx.outDir, "public"),
bindings: {
ASSETS: {
fetch: async (request) => {
const contents = await fsp.readFile(
join(ctx.outDir, new URL(request.url).pathname)
);
return new _Response(contents);
},
},
});
},
});

testNitro(ctx, () => {
return async ({ url, headers, method, body }) => {
const res = await mf.dispatchFetch("http://localhost" + url, {
headers: headers || {},
Expand All @@ -35,4 +35,10 @@ describe("nitro:preset:cloudflare-module", async () => {
return res as unknown as Response;
};
});

it("should handle scheduled events", async () => {
const waitUntil = await mf.dispatchScheduled();
// console.log("WAIT:M", waitUntil); // Event is sent and hook is called, but waitUntil doesn't work.
expect(waitUntil[0]).toBe("scheduled:cloudflare-module");
});
});
14 changes: 10 additions & 4 deletions test/presets/cloudflare.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { promises as fsp } from "node:fs";
import { resolve } from "pathe";
import { Miniflare } from "miniflare";
import { describe, it, expect } from "vitest";
Expand All @@ -7,10 +6,11 @@ import { setupTest, testNitro } from "../tests";

describe("nitro:preset:cloudflare", async () => {
const ctx = await setupTest("cloudflare");
const mf = new Miniflare({
scriptPath: resolve(ctx.outDir, "server/index.mjs"),
});

testNitro(ctx, () => {
const mf = new Miniflare({
scriptPath: resolve(ctx.outDir, "server/index.mjs"),
});
return async ({ url, headers, method, body }) => {
const res = await mf.dispatchFetch("http://localhost" + url, {
headers: headers || {},
Expand All @@ -20,4 +20,10 @@ describe("nitro:preset:cloudflare", async () => {
return res as unknown as Response;
};
});

it("should handle scheduled events", async () => {
const waitUntil = await mf.dispatchScheduled();
// console.log("WAIT", waitUntil); // Event is sent and hook is called, but waitUntil doesn't work.
expect(waitUntil[0]).toBe(undefined);
});
});