Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deploy): add platform.sh #1630

Merged
merged 6 commits into from
Feb 27, 2024
Merged

docs(deploy): add platform.sh #1630

merged 6 commits into from
Feb 27, 2024

Conversation

oritwoen
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I've been using platform.sh recently and thought I'd add some information about deploy there.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Aug 24, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 8724428

@oritwoen
Copy link
Contributor Author

I updated the information and configuration to Nitro 2.6 requirements.

@oritwoen
Copy link
Contributor Author

@pi0 I'm changing it to draft until Nuxt 3.8, Nitro 2.7 and the stable version of @nuxt/image come out.

With the number of changes that are to be made in the new releases, I am almost sure that it will be necessary to slightly modify the deployment configuration to platform.sh.

@oritwoen oritwoen marked this pull request as draft October 14, 2023 13:12
@pi0
Copy link
Member

pi0 commented Oct 16, 2023

Thanks for your working on this. BTW we don't block Nuxt/Nitro releases. They are always in parallel and platform support is open to every one/framework.

Nitro preset implementation also shall remain completely framework agnostic so i expect we consider them. Can you please mention your concerns/checklist of features you think might be needed from preset?

@oritwoen
Copy link
Contributor Author

oritwoen commented Oct 16, 2023

I may have expressed myself incorrectly. In platform.sh you can use node or bun and in the configuration from this PR everything works beautifully.

However, I tried to run @nuxt/image on this platform and it gives me some problems, I have not yet figured out whether it is related to ipx or the module itself. For each use of disk writing, you need to mount paths in the configuration, and for reading (e.g. ipx path) that returns media, slight configuration changes are also required. I may also simply not have enough RAM on the instance, I'm checking it.

I also saw in the latest RC for image that a potentially stable version will have autoinstall into Nuxt.

Hence, I wanted to wait and test it after the release of new versions of @nuxt/image and Nuxt 3.8 whether the problem will still occur with new stable releases.

@pi0
Copy link
Member

pi0 commented Oct 16, 2023

Yes, we are releasing stable image module for nuxt soon and it shall also support this platform. However this a completely separate matter.

Anything else blocking this to land?

@oritwoen oritwoen marked this pull request as ready for review October 16, 2023 23:22
@oritwoen
Copy link
Contributor Author

I only had problems with @nuxt/image, everything else works great.

I have been using this setup for over a month. You made me realize that I shouldn't have thought too much about it. If you don't have any additional comments, feel free to merge :)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay. i have pushed some updates to simplify (but haven't tested feel free to amend PR changes). Lets iterate πŸ‘πŸΌ

@pi0 pi0 merged commit 2436e6a into unjs:main Feb 27, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants