-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add types:extend
hook
#1715
Conversation
@pi0 any update on this? |
@mukundshah Sorry for delay it is on my check list to review asap for next minor ππΌ |
@pi0 no worries; Thank you for reply and update ;) |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #1715 +/- ##
===========================================
+ Coverage 51.94% 76.17% +24.23%
===========================================
Files 174 76 -98
Lines 12035 8031 -4004
Branches 913 804 -109
===========================================
- Hits 6252 6118 -134
+ Misses 5686 1911 -3775
+ Partials 97 2 -95 β View full report in Codecov by Sentry. |
/cc @danielroe i am thinking about |
It might be worth deferring this until I finish updating #1532 as we will probably want to change what we pass in the hook. |
Sure we can wait. Also this is an object we are passing so if you are generally okay with naming, we can merge and iterate to extend it later. Please let me know which method you prefer. |
Your thought on naming seems good to me π |
π Linked issue
#1710
β Type of change
π Description
π Checklist