Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental winterjs preset #1863

Merged
merged 16 commits into from
Oct 28, 2023
Merged

feat: add experimental winterjs preset #1863

merged 16 commits into from
Oct 28, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 28, 2023

πŸ”— Linked issue

Resolves #1861

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Note that this is a very experimental preset and many of the feature are not working properly or are hotfixes. And also when testing externally against Nuxt, there are hanging issues.

This PR enables an easier way to move forward to officially support winterjs/wasmer

TODO:

  • Support serve static (partial)
  • Fix failing tests (9 skipped)
  • Integrate waitUntil API
  • Add docs page

Latest status: #1861

/cc @syrusakbary @Arshia001

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 marked this pull request as draft October 28, 2023 19:12
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1863 (127e7f5) into main (ac137d9) will decrease coverage by 0.51%.
The diff coverage is 8.53%.

@@            Coverage Diff             @@
##             main    #1863      +/-   ##
==========================================
- Coverage   52.38%   51.88%   -0.51%     
==========================================
  Files         172      174       +2     
  Lines       11910    12035     +125     
  Branches      912      909       -3     
==========================================
+ Hits         6239     6244       +5     
- Misses       5575     5693     +118     
- Partials       96       98       +2     
Files Coverage Ξ”
src/build.ts 83.80% <100.00%> (ΓΈ)
src/presets/index.ts 100.00% <100.00%> (ΓΈ)
src/presets/winterjs.ts 100.00% <100.00%> (ΓΈ)
src/runtime/utils.lambda.ts 0.00% <0.00%> (ΓΈ)
src/runtime/utils.ts 0.00% <0.00%> (ΓΈ)
src/runtime/entries/winterjs.ts 0.00% <0.00%> (ΓΈ)

... and 2 files with indirect coverage changes

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Oct 28, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 6e73cf1

@pi0 pi0 marked this pull request as ready for review October 28, 2023 23:32
@pi0 pi0 mentioned this pull request Oct 28, 2023
6 tasks
@pi0 pi0 merged commit e8fa771 into main Oct 28, 2023
8 of 9 checks passed
@pi0 pi0 deleted the feat/winterjs branch October 28, 2023 23:35
@pi0 pi0 mentioned this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinterJS runtime support
1 participant