Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deno-deploy): use Deno.serve #1879

Merged
merged 9 commits into from
Nov 3, 2023
Merged

refactor(deno-deploy): use Deno.serve #1879

merged 9 commits into from
Nov 3, 2023

Conversation

markthree
Copy link
Contributor

@markthree markthree commented Nov 3, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

deno deploy already supports Deno.serve and std/http/serve is deprecated.

This small change will theoretically reduce nitro's cold-start time during deno deploy and the service will perform better! πŸ₯°

Ref:

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title perf(runtime/deno-deploy): replace std/http/serve with native Deno.serve refactor(deno-deploy): use Deno.serve Nov 3, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit b3dbcb2 into unjs:main Nov 3, 2023
4 checks passed
@pi0 pi0 mentioned this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants