Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate route typed with resolve path and stripped extension #1897

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 8, 2023

πŸ”— Linked issue

Resolves #1378

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We were not resolving event handler paths for generating types and also removing any last .* segment. So if input is ~/foo.get, generated type would be something like ../~/foo.

This PR both resolves paths and strips only known extension from last (it is unnecessary but as another safety measure)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe November 8, 2023 22:27
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pi0 pi0 merged commit 37e9f2b into main Nov 8, 2023
4 of 5 checks passed
@pi0 pi0 deleted the fix/type-imports branch November 8, 2023 22:31
@pi0 pi0 mentioned this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nitro-routes not generated properly for filename separated by dots like handler.get.ts
2 participants