Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): decode uris in headers #1932

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix(prerender): decode uris in headers #1932

merged 1 commit into from
Nov 20, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#1914
https://github.com/nuxt/nuxt/actions/runs/6923600748/job/18832536383?pr=24370#step:13:66

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Because we are using the scanned links to create a new URL we need to ensure they are decoded first:

nitro/src/prerender.ts

Lines 396 to 404 in df7091d

const _link = parseURL(link);
if (_link.protocol) {
continue;
}
if (!_link.pathname.startsWith("/")) {
const fromURL = new URL(from, "http://localhost");
_link.pathname = new URL(_link.pathname, fromURL).pathname;
}
links.push(_link.pathname + _link.search);

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working prerender labels Nov 20, 2023
@danielroe danielroe requested a review from pi0 November 20, 2023 09:51
@danielroe danielroe self-assigned this Nov 20, 2023
@pi0 pi0 merged commit 30e1c13 into main Nov 20, 2023
5 checks passed
@pi0 pi0 deleted the fix/decode-headers branch November 20, 2023 09:52
@pi0 pi0 mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prerender
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants