Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerenderer): write responses with json signature to original path #1963

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 28, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

See #1962 and nuxt/nuxt#24487 for some context

When prerendering, a route without .html extension (like /foo or /foo.json, etc) could contain a JSON response (wrongly because returned by h3 handler or a SSR renderer).

Nitro were trusting purely on content-type to detect HTML routes and write /foo to public/foo/index.html.

With this PR, if response contents of /foo contains a JSON signature, we write it to public/foo as-is.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit b53e001 into main Nov 28, 2023
5 checks passed
@pi0 pi0 deleted the fix/prerender-sig branch November 28, 2023 12:40
@pi0 pi0 changed the title fix(prerenderer): write responses with json signuture to original path fix(prerenderer): write responses with json signature to original path Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants