-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cloudflare): various updates, cleanups and fixes #1981
Conversation
`wrangler dev` doesn't require `--local` anymore (and it will be removed in a future major version) so remove it from the cloudflare docs
the latest version of wrangler (recommended to use) is 3, so in the "wrangler2" text remove the incorrect '2' Note: instead of setting the test to "wrangler3" let's set it to "wrangler" so that this won't need to be updated as there are major wrangler bumps
- instead of using `yarn` sometimes and `npm` so other times, consistently use `npm` - globally installing `wrangler` is not advised (it was once), so remove such suggestions
β Live Preview ready!
|
with: | ||
path: node_modules | ||
key: ${{ matrix.os }}-node-v${{ matrix.node }}-deps-${{ hashFiles(format('{0}{1}', github.workspace, '/yarn.lock')) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the caching as it looks like an extra step unrelated to this document
(and I feel that keeping things scoped/minimal/simple makes for a better/more useful yml example here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New node setup action has built-in caching we can opt-in ππΌ
Thanks for PR β€οΈ (and sorry for delay on merge) |
No problem at all, it's my pleasure, thanks for the merge π |
β Type of change
π Description
In the cloudflare docs page I've found outdated/incorrect details which I am amending here.
Besides that I am also updating and improving some other few bits.
To see the what the various changes are please look at the commit messages.