docs(cloudflare): various updates, cleanups and fixes #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wrangler dev` doesn't require `--local` anymore (and it will be removed in a future major version) so remove it from the cloudflare docs
the latest version of wrangler (recommended to use) is 3, so in the "wrangler2" text remove the incorrect '2' Note: instead of setting the test to "wrangler3" let's set it to "wrangler" so that this won't need to be updated as there are major wrangler bumps
- instead of using `yarn` sometimes and `npm` so other times, consistently use `npm` - globally installing `wrangler` is not advised (it was once), so remove such suggestions
✅ Live Preview ready!
|
dario-piotrowicz
commented
Dec 3, 2023
| with: | ||
| path: node_modules | ||
| key: ${{ matrix.os }}-node-v${{ matrix.node }}-deps-${{ hashFiles(format('{0}{1}', github.workspace, '/yarn.lock')) }} |
There was a problem hiding this comment.
I've removed the caching as it looks like an extra step unrelated to this document
(and I feel that keeping things scoped/minimal/simple makes for a better/more useful yml example here)
There was a problem hiding this comment.
New node setup action has built-in caching we can opt-in 👍🏼
pi0
reviewed
Dec 13, 2023
pi0
reviewed
Dec 13, 2023
pi0
reviewed
Dec 13, 2023
pi0
reviewed
Dec 13, 2023
|
Thanks for PR ❤️ (and sorry for delay on merge) |
No problem at all, it's my pleasure, thanks for the merge 😄 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
In the cloudflare docs page I've found outdated/incorrect details which I am amending here.
Besides that I am also updating and improving some other few bits.
To see the what the various changes are please look at the commit messages.