Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve modules with jiti directly #2030

Merged
merged 16 commits into from
Feb 27, 2024
Merged

fix: resolve modules with jiti directly #2030

merged 16 commits into from
Feb 27, 2024

Conversation

huang-julien
Copy link
Contributor

@huang-julien huang-julien commented Dec 25, 2023 •
edited
Loading

🔗 Linked issue

fix #2029

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 this PR pass alias directly to jiti() which will use pass it down to the now fixed resolvePath() of mlly

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

pi0
pi0 reviewed Dec 25, 2023
View reviewed changes
src/module.ts Show resolved Hide resolved
pi0
pi0 reviewed Dec 25, 2023
View reviewed changes
test/e2e/basic.test.ts Outdated Show resolved Hide resolved
@huang-julien huang-julien changed the title feat(modules): allow to declare packages as nitro modules fix(modules): allow to declare packages as nitro modules Dec 25, 2023
@huang-julien huang-julien mentioned this pull request Dec 27, 2023
Closed
@huang-julien huang-julien marked this pull request as draft January 19, 2024 09:35
@huang-julien huang-julien changed the title fix(modules): allow to declare packages as nitro modules fix(modules): pass alias directly to jiti Jan 27, 2024
@huang-julien huang-julien marked this pull request as ready for review January 27, 2024 20:55
@huang-julien
Copy link
Contributor Author

huang-julien commented Jan 28, 2024 •
edited
Loading

jiti is now correctly resolving both alias and modules ! 🎉

@pi0 pi0 changed the title fix(modules): pass alias directly to jiti fix: resolve modules with jiti directly Feb 27, 2024
@pi0 pi0 merged commit 7aec22c into unjs:main Feb 27, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Feb 27, 2024
Closed
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot declare a package module as module in the nitro config
2 participants
@huang-julien @pi0