Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): pass body to the context as-is #2079

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix(azure): pass body to the context as-is #2079

merged 1 commit into from
Jan 16, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 16, 2024

πŸ”— Linked issue

resolves #100

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When sending a binary/Buffer response, azure natively handles it and we don't need to stringify it. (Note: h3 stringifies objects and alike already)

PS: I locally confirmed working based on tests in #2076

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit cdb0ee4 into main Jan 16, 2024
5 checks passed
@pi0 pi0 deleted the fix/azure-binary2 branch January 16, 2024 13:38
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images are incorrectly encoded after Azure Functions Deployment
1 participant