-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(github-pages): add --dotfiles
to deploy command hint
#2158
Conversation
Without `--dotfiles` `gh-pages` does not deploy `.nojekyl`
Have you tried
|
This should also work. Went with --dotfiles because the preset already creates .nojekyl file. And I believe this is better, as users may decide to deploy without using 3rd party gh-pages utility. |
Main issue is that there might be dot files that are dangerous to be published. I think users they always have this choice and this is just a "hint" how to deploy. Sticking with safest is probably better while you might want to publish all dot files. (also the fact that gh pages CLI itself chose this default behavior) |
Following the current hint leads to broken deployment. I have considered four solutions:
The mentioned docs already suggest deploying
|
It is odd for GitHub pages that ignore But fair enough for other common dirs, it might came useful and hint is already clear what user is doing ππΌ |
--dotfiles
to deploy command hint
|
β Type of change
π Description
Without
--dotfiles
gh-pages
does not deploy.nojekyl
Ref: https://www.npmjs.com/package/gh-pages#optionsdotfiles
π Checklist