fix(externals): skip resolving virtual ids start with \0
#2321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
analogjs/analog#969 (comment)
Reproduction: https://github.com/brandonroberts/analog-nitro-295
β Type of change
π Description
This PR fixes an issue revealed by #2289.
After calling (rollup)
this.resolve
, the result might be a virtual import starting with\0
which we shouldn't attempt to resolve using build-in ESM resolution (mlly).π Checklist