Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): only try to add / after prerender:routes hook #2348

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is more a proposal for discussion - please feel free to close if you disagree.

As Nitro is becoming less opinionated, I think it might be good to avoid defaulting to prerendering the / route. It makes it difficult for frameworks to know whether this path has been explicitly added by a user or module hook, or whether this is a Nitro default.

I'm looking to resolve nuxt/nuxt#26694, and we can work around this for that PR but I think it would be simpler for a framework to add the list and not have to remove any defaults.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 April 10, 2024 07:55
@danielroe danielroe changed the title fix: do not add / if no routes specified fix(prerender): do not add / if no routes specified Apr 10, 2024
src/prerender.ts Show resolved Hide resolved
@pi0 pi0 changed the title fix(prerender): do not add / if no routes specified fix(prerender): only try to add / after prerender:routes hook Apr 29, 2024
@pi0 pi0 merged commit fb88efd into main Apr 29, 2024
4 of 5 checks passed
@pi0 pi0 deleted the fix/explicit-prerender branch April 29, 2024 19:59
@pi0 pi0 mentioned this pull request Jun 13, 2024
pi0 added a commit that referenced this pull request Jun 27, 2024
)

Co-authored-by: Pooya Parsa <pooya@pi0.io>
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants