Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set compilerOptions.noEmit to avoid tsconfig.json warning #2402

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/eslint#414

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This sets noEmit which is correct for a tsconfig.json meant primarily for IDE type hinting.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented Apr 29, 2024

How this affects nitro behavior?

@danielroe
Copy link
Member Author

It won’t affect any behaviour outside of ide type hints (without this PR, you’ll get an IDE warning when you use JS files in a nitro project)

@pi0
Copy link
Member

pi0 commented Apr 29, 2024

Sorry if my message seems stupid, but how i can see such a warning in a nitro project?

@danielroe
Copy link
Member Author

I’ll provide a screenshare later as I’m just having dinner. But it’s definitely the right thing to do. See https://www.totaltypescript.com/tsconfig-cheat-sheet - there are likely more things we should bring in from that article too…

@pi0
Copy link
Member

pi0 commented Apr 29, 2024

It is a harmless config but i won't merge a PR without a nitro minimal reproduction or at least enough merits. Currently only linked reason is a closed issue in eslint module.

@danielroe
Copy link
Member Author

Here you go.

Hope this helps explain.

CleanShot.2024-04-29.at.19.32.04.mp4

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielroe
Copy link
Member Author

You are very welcome 😊

@pi0 pi0 changed the title fix: set compilerOptions.noEmit fix: set compilerOptions.noEmit to avoid tsconfig.json warning Apr 29, 2024
@pi0 pi0 merged commit 6b6777e into main Apr 29, 2024
5 checks passed
@pi0 pi0 deleted the fix/no-emit branch April 29, 2024 19:02
@pi0 pi0 mentioned this pull request Jun 13, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants