-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set compilerOptions.noEmit
to avoid tsconfig.json
warning
#2402
Conversation
How this affects nitro behavior? |
It wonβt affect any behaviour outside of ide type hints (without this PR, youβll get an IDE warning when you use JS files in a nitro project) |
Sorry if my message seems stupid, but how i can see such a warning in a nitro project? |
Iβll provide a screenshare later as Iβm just having dinner. But itβs definitely the right thing to do. See https://www.totaltypescript.com/tsconfig-cheat-sheet - there are likely more things we should bring in from that article tooβ¦ |
It is a harmless config but i won't merge a PR without a nitro minimal reproduction or at least enough merits. Currently only linked reason is a closed issue in eslint module. |
Here you go. Hope this helps explain. CleanShot.2024-04-29.at.19.32.04.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
You are very welcome π |
compilerOptions.noEmit
compilerOptions.noEmit
to avoid tsconfig.json
warning
π Linked issue
nuxt/eslint#414
β Type of change
π Description
This sets
noEmit
which is correct for atsconfig.json
meant primarily for IDE type hinting.π Checklist